New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use buf.String() instead of string(buf.Bytes()) #1715

Open

testwill wants to merge 2 commits into gocql:master from testwill:string

testwill commented Jul 14, 2023

No description provided.


          chore: use buf.String() instead of string(buf.Bytes())

48025ec

Contributor

martin-sucha commented Jul 17, 2023

Hi!

Thank you for the pull request! The change looks good to me, but I have two questions:

You have Github vigilant mode enabled, but the commit is not signed. Is that intentional?
It seems to me that we could use strings.Builder instead of *bytes.Buffer. That should save an allocation. What do you think?


          fix: use strings.Builder instead of *bytes.Buffer

1abe6cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment