Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HostFilter Not Used for Control Connection #1724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amcrn
Copy link

@amcrn amcrn commented Sep 14, 2023

The HostFilter is not being used for the Control Connection (aka the controlConn). This can be problematic, especially if the host is being filtered due to it being in a bad state, as it can hold up the creation of the Control Connection (and therefore the Session itself) for quite some time.

This also fixes an issue if disableControlConn=true and/or DisableInitialHostLookup=true, where the Ring is updated with the host, prior to filtering:

gocql/session.go

Lines 265 to 268 in db6d556

host := s.ring.addOrUpdate(host)
if s.cfg.filterHost(host) {
continue
}

Closes: #1723

The `HostFilter` is not being used for the Control Connection (aka
the `controlConn`). This can be problematic, especially if the host
is being filtered due to it being in a bad state, as it can hold up
the creation of the Control Connection (and therefore the Session
itself) for quite some time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HostFilter Not Used for Control Connection
1 participant