MaxRequestsPerConn cluster param was added #1747
Open
+48
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martin-sucha Hello, will be glad to receive your review on this PR! |
taaraora
reviewed
May 23, 2024
conn.go
Outdated
| @@ -257,7 +257,7 @@ func (s *Session) dialWithoutObserver(ctx context.Context, host *HostInfo, cfg * | |||
| errorHandler: errorHandler, | |||
| compressor: cfg.Compressor, | |||
| session: s, | |||
| streams: streams.New(cfg.ProtoVersion), | |||
| streams: s.streamIDGenerator(cfg.ProtoVersion), | |||
There was a problem hiding this comment.
what if we call it newStreamIDGenerator?
Also is it obligatory to pass config there if we access cfg from attached type?
There was a problem hiding this comment.
Fixed, renamed and moved the function to the streams package.
taaraora
reviewed
May 23, 2024
| defer h.mu.Unlock() | ||
| addr, _ := h.connectAddressLocked() | ||
| return net.JoinHostPort(addr.String(), strconv.Itoa(h.port)) | ||
| h.mu.Lock() |
There was a problem hiding this comment.
I don't think it makes sense to format files which were not touched by the fix.
There was a problem hiding this comment.
Reverted these changes, but it seems that they stayed inside this PR :\
testisnullus
force-pushed
the
maxRequestsPerConn-cluster-param
branch
2 times, most recently
from
3c070c3
to
ba0fac8
Compare
testisnullus
force-pushed
the
maxRequestsPerConn-cluster-param
branch
from
ba0fac8
to
88405bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a user to configure the maximum requests per connection parameter by a newly added MaxRequestsPerConn option.
Closes #1679
Functionality was adopted from similar PR from the ScyllaDB project: scylladb#113