[Core] Use LocalVector
for MethodInfo::arguments
#91660
Open
+112
−128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the bigger offenders when it comes to using a bidirectional data type for random-access purposes, there aren't really any good reasons to use a
List
here that I can tell, we never do any insertions or erasures on it (one case inNode
but it wasn't necessary, and IMO worsened readability)Might be relevant to change the other containers in this type from
Vector
toLocalVector
but might not matterNothing should really change here except improving some data management, and locality, and making accessing the arguments easier, performance should be unaffected either way but haven't done any direct testing on that part, but I don't think this data is used in critical paths anyway
Follow-up to:
List
#90705