Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Use LocalVector for MethodInfo::arguments #91660

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AThousandShips
Copy link
Member

One of the bigger offenders when it comes to using a bidirectional data type for random-access purposes, there aren't really any good reasons to use a List here that I can tell, we never do any insertions or erasures on it (one case in Node but it wasn't necessary, and IMO worsened readability)

Might be relevant to change the other containers in this type from Vector to LocalVector but might not matter

Nothing should really change here except improving some data management, and locality, and making accessing the arguments easier, performance should be unaffected either way but haven't done any direct testing on that part, but I don't think this data is used in critical paths anyway

Follow-up to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant