Fix i18n in AudioStreamInteractive transition editor #91693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timothyqiu
commented
May 8, 2024
timothyqiu
commented
- Don't translate user-defined clip names.
- Add missing i18n for some UI strings.
- Also fixed error when selecting top-right "From/To" cell.
- Also removed unused header includes.
timothyqiu
commented
May 8, 2024
Comment on lines
-223
to
+226
| txt += TTR(L"⮕ Same"); | ||
| to_time = TTR("Same", "Transition Time Position"); | ||
| } break; | ||
| case AudioStreamInteractive::TRANSITION_TO_TIME_START: { | ||
| txt += TTR(L"⮕ Start"); | ||
| to_time = TTR("Start", "Transition Time Position"); | ||
| } break; | ||
| case AudioStreamInteractive::TRANSITION_TO_TIME_PREVIOUS_POSITION: { | ||
| txt += TTR(L"⮕ Prev"); | ||
| to_time = TTR("Prev", "Transition Time Position"); |
There was a problem hiding this comment.
U""literals are used instead ofL""literals throughout the codebase.- Using
L""literal insideTTR()is not supported by extraction scripts. - Moved
⮕into a separate format string below so strings are easier to translate.
akien-mga
reviewed
May 8, 2024
modules/interactive_music/editor/audio_stream_interactive_editor_plugin.cpp
Outdated
Show resolved
Hide resolved
akien-mga
approved these changes
May 8, 2024
- Don't translate user-defined clip names. - Add missing i18n for some UI strings. - Also fixed error when selecting top-right "From/To" cell. - Also removed unused header includes.
timothyqiu
force-pushed
the
interactive-editor
branch
from
1ccb464
to
4a316c4
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.