feat: HCaptcha Middleware #1071
Conversation
bndrmrtn
requested review from
gaby,
sixcolors,
ReneWerner87 and
efectn
and removed request for
a team
WalkthroughThe recent changes introduce a robust Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| res, err := app.Test(req, -1) | ||
| defer res.Body.Close() |
There was a problem hiding this comment.
Ensure defer res.Body.Close() is called after checking for an error from app.Test(req, -1) to avoid potential nil pointer dereference.
- defer res.Body.Close()
res, err := app.Test(req, -1)
+ if err != nil {
+ t.Fatal(err)
+ }
+ defer res.Body.Close()Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| res, err := app.Test(req, -1) | |
| defer res.Body.Close() | |
| res, err := app.Test(req, -1) | |
| if err != nil { | |
| t.Fatal(err) | |
| } | |
| defer res.Body.Close() |
hcaptcha/hcaptcha.go
Outdated
| req.Header.SetMethod("POST") | ||
| req.Header.SetContentType("application/x-www-form-urlencoded; charset=UTF-8") | ||
| req.Header.Set("Accept", "application/json") | ||
| req.SetRequestURI(c.Host()) |
There was a problem hiding this comment.
Set the request URI to h.SiteVerifyURL instead of c.Host() for the HCaptcha API call.
- req.SetRequestURI(c.Host())
+ req.SetRequestURI(h.SiteVerifyURL)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| req.SetRequestURI(c.Host()) | |
| req.SetRequestURI(h.SiteVerifyURL) |
|
I added it to the root README and I created a README file for it, I tried to enable dependabot, but I don't know how to excatly enable workflows for this pull request. I never did it before, that's new for me :// |
|
@bndrmrtn Copy one of the test workflows for the other contrib middlewares, and adapt it to this one. |
|
I think I did it, right? 🤔 |
|
will check it tomorrow |
|
pls add a section like this contrib/.github/dependabot.yml Lines 101 to 106 in f6a1c31 and copy the release drafter yaml´s |
fix dependabot.yml
Hcaptcha middleware
|
@bndrmrtn pls don't create useless pull requests |
yeah, really sorry 😅 |
ReneWerner87
added
✏️ Feature
fixed with f5b94a8 |
|
@gaby @sixcolors @efectn can you check |
|
Thanks! 🤩 |
Summary by CodeRabbit
New Features
Documentation
Tests
Chores