fix: utils.Trim should trim all string content (#1775)

* fix: `utils.Trim` should trim all string content * add empty string input * better fix
gofiber · Feb 14, 2022 · 391ae59 · 391ae59
1 parent 937713e
commit 391ae59
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/utils/strings.go b/utils/strings.go
@@ -43,7 +43,7 @@ func Trim(s string, cutset byte) string {
 			break
 		}
 	}
-	for ; i < j; j-- {
+	for ; i <= j; j-- {
 		if s[j] != cutset {
 			break
 		}

diff --git a/utils/strings_test.go b/utils/strings_test.go
@@ -126,6 +126,15 @@ func Test_Trim(t *testing.T) {
 
 	res = Trim(".test", '.')
 	AssertEqual(t, "test", res)
+
+	res = Trim(" ", ' ')
+	AssertEqual(t, "", res)
+
+	res = Trim("  ", ' ')
+	AssertEqual(t, "", res)
+
+	res = Trim("", ' ')
+	AssertEqual(t, "", res)
 }
 
 func Benchmark_Trim(b *testing.B) {