Refactor favicon middleware, avoid magic numbers. (#1919)

* Refactor favicon middleware, avoid magic numbers. * Introduce constant for path to favicon.
gofiber · May 28, 2022 · 68e922d · 68e922d · ReneWerner87 · May 28, 2022
1 parent 061c2a9
commit 68e922d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/middleware/favicon/favicon.go b/middleware/favicon/favicon.go
@@ -40,6 +40,7 @@ var ConfigDefault = Config{
 }
 
 const (
+	fPath  = "/favicon.ico"
 	hType  = "image/x-icon"
 	hAllow = "GET, HEAD, OPTIONS"
 	hZero  = "0"
@@ -97,7 +98,7 @@ func New(config ...Config) fiber.Handler {
 		}
 
 		// Only respond to favicon requests
-		if len(c.Path()) != 12 || c.Path() != "/favicon.ico" {
+		if c.Path() != fPath {
 			return c.Next()
 		}