CookieSameSite default "Lax" (#1640)

gofiber · Dec 2, 2021 · af6b204 · af6b204 · Fenny · Dec 2, 2021
1 parent c9e959c
commit af6b204
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/middleware/csrf/README.md b/middleware/csrf/README.md
@@ -46,7 +46,7 @@ app.Use(csrf.New()) // Default config
 app.Use(csrf.New(csrf.Config{
 	KeyLookup:      "header:X-Csrf-Token",
 	CookieName:     "csrf_",
-	CookieSameSite: "Strict",
+	CookieSameSite: "Lax",
 	Expiration:     1 * time.Hour,
 	KeyGenerator:   utils.UUID,
 }))
@@ -106,7 +106,7 @@ type Config struct {
 	CookieHTTPOnly bool
 
 	// Indicates if CSRF cookie is requested by SameSite.
-	// Optional. Default value "Strict".
+	// Optional. Default value "Lax".
 	CookieSameSite string
 
 	// Expiration is the duration before csrf token will expire
@@ -138,7 +138,7 @@ type Config struct {
 var ConfigDefault = Config{
 	KeyLookup:      "header:X-Csrf-Token",
 	CookieName:     "csrf_",
-	CookieSameSite: "Strict",
+	CookieSameSite: "Lax",
 	Expiration:     1 * time.Hour,
 	KeyGenerator:   utils.UUID,
 }

diff --git a/middleware/csrf/config.go b/middleware/csrf/config.go
@@ -50,7 +50,7 @@ type Config struct {
 	CookieHTTPOnly bool
 
 	// Value of SameSite cookie.
-	// Optional. Default value "Strict".
+	// Optional. Default value "Lax".
 	CookieSameSite string
 
 	// Expiration is the duration before csrf token will expire
@@ -96,7 +96,7 @@ type Config struct {
 var ConfigDefault = Config{
 	KeyLookup:      "header:X-Csrf-Token",
 	CookieName:     "csrf_",
-	CookieSameSite: "Strict",
+	CookieSameSite: "Lax",
 	Expiration:     1 * time.Hour,
 	KeyGenerator:   utils.UUID,
 	ErrorHandler:   defaultErrorHandler,
Benchmark suite	Current: `af6b204`	Previous: `c9e959c`	Ratio
`Benchmark_App_ETag`	`9819` ns/op 1044 B/op 3 allocs/op	`3611` ns/op 1044 B/op 3 allocs/op	`2.72`
`Benchmark_App_ETag_Weak`	`7368` ns/op 1076 B/op 4 allocs/op	`3683` ns/op 1076 B/op 4 allocs/op	`2.00`
`Benchmark_Ctx_Write`	`65.5` ns/op 72 B/op 0 allocs/op	`30.9` ns/op 71 B/op 0 allocs/op	`2.12`
`Benchmark_Utils_ETag`	`7441` ns/op 1044 B/op 3 allocs/op	`3620` ns/op 1044 B/op 3 allocs/op	`2.06`
`Benchmark_Utils_ETag_Weak`	`7417` ns/op 1076 B/op 4 allocs/op	`3695` ns/op 1076 B/op 4 allocs/op	`2.01`