Fix route naming when to use group in group. (#1736)

gofiber · Jan 29, 2022 · d3c2122 · d3c2122
1 parent 6036f40
commit d3c2122
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/app_test.go b/app_test.go
@@ -561,10 +561,14 @@ func Test_App_Route_Naming(t *testing.T) {
 
 	app.Post("/post", handler).Name("post")
 
+	subGroup := jane.Group("/sub-group").Name("sub.")
+	subGroup.Get("/done", handler).Name("done")
+
 	utils.AssertEqual(t, "post", app.GetRoute("post").Name)
 	utils.AssertEqual(t, "john", app.GetRoute("john").Name)
 	utils.AssertEqual(t, "jane.test", app.GetRoute("jane.test").Name)
 	utils.AssertEqual(t, "jane.trace", app.GetRoute("jane.trace").Name)
+	utils.AssertEqual(t, "jane.sub.done", app.GetRoute("jane.sub.done").Name)
 	utils.AssertEqual(t, "test", app.GetRoute("test").Name)
 }
 

diff --git a/group.go b/group.go
@@ -48,7 +48,12 @@ func (grp *Group) Mount(prefix string, fiber *App) Router {
 
 // Assign name to specific route.
 func (grp *Group) Name(name string) Router {
-	grp.name = name
+	if strings.HasPrefix(grp.prefix, latestGroup.prefix) {
+		grp.name = latestGroup.name + name
+	} else {
+		grp.name = name
+	}
+
 	latestGroup = *grp
 
 	return grp