Skip to content

Commit

Permalink
🧹 client: remove beta warning (#1951)
Browse files Browse the repository at this point in the history
* 🧹 client: remove beta warning

* Stabilize the Test_Test_Timeout unittest

Co-authored-by: wernerr <rene@gofiber.io>
  • Loading branch information
efectn and ReneWerner87 committed Jul 4, 2022
1 parent b6818c2 commit dac929f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion app_test.go
Expand Up @@ -1299,7 +1299,7 @@ func Test_Test_Timeout(t *testing.T) {
utils.AssertEqual(t, 200, resp.StatusCode, "Status code")

app.Get("timeout", func(c *Ctx) error {
time.Sleep(55 * time.Millisecond)
time.Sleep(100 * time.Millisecond)
return nil
})

Expand Down
5 changes: 0 additions & 5 deletions client.go
Expand Up @@ -738,14 +738,9 @@ func (a *Agent) RetryIf(retryIf RetryIfFunc) *Agent {
}

/************************** End Agent Setting **************************/
var warnOnce sync.Once

// Bytes returns the status code, bytes body and errors of url.
func (a *Agent) Bytes() (code int, body []byte, errs []error) {
warnOnce.Do(func() {
fmt.Println("[Warning] client is still in beta, API might change in the future!")
})

defer a.release()

if errs = append(errs, a.errs...); len(errs) > 0 {
Expand Down

1 comment on commit dac929f

@ReneWerner87
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: dac929f Previous: b6818c2 Ratio
Benchmark_App_ETag 6663 ns/op 1044 B/op 3 allocs/op 3269 ns/op 1044 B/op 3 allocs/op 2.04

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.