Skip to content

Commit

Permalink
📖 fix ListenTLS comment (#1859)
Browse files Browse the repository at this point in the history
* 📖 fix ListenTLS comment

* 📖 fix ListenMutualTLS comment
  • Loading branch information
jfcg committed Apr 14, 2022
1 parent f19ef67 commit e7ec08a
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions app.go
Expand Up @@ -828,10 +828,8 @@ func (app *App) Listen(addr string) error {
return app.server.Serve(ln)
}

// ListenTLS serves HTTPs requests from the given addr.
// certFile and keyFile are the paths to TLS certificate and key file.

// app.ListenTLS(":8080", "./cert.pem", "./cert.key")
// ListenTLS serves HTTPS requests from the given addr.
// certFile and keyFile are the paths to TLS certificate and key file:
// app.ListenTLS(":8080", "./cert.pem", "./cert.key")
func (app *App) ListenTLS(addr, certFile, keyFile string) error {
// Check for valid cert/key path
Expand Down Expand Up @@ -871,10 +869,8 @@ func (app *App) ListenTLS(addr, certFile, keyFile string) error {
return app.server.ServeTLS(ln, certFile, keyFile)
}

// ListenMutualTLS serves HTTPs requests from the given addr.
// certFile, keyFile and clientCertFile are the paths to TLS certificate and key file.

// app.ListenMutualTLS(":8080", "./cert.pem", "./cert.key", "./client.pem")
// ListenMutualTLS serves HTTPS requests from the given addr.
// certFile, keyFile and clientCertFile are the paths to TLS certificate and key file:
// app.ListenMutualTLS(":8080", "./cert.pem", "./cert.key", "./client.pem")
func (app *App) ListenMutualTLS(addr, certFile, keyFile, clientCertFile string) error {
// Check for valid cert/key path
Expand Down

1 comment on commit e7ec08a

@Fenny
Copy link
Member

@Fenny Fenny commented on e7ec08a Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: e7ec08a Previous: f19ef67 Ratio
Benchmark_Ctx_Write 69.32 ns/op 75 B/op 0 allocs/op 29.04 ns/op 78 B/op 0 allocs/op 2.39
Benchmark_TrimLeft/fiber 14.23 ns/op 0 B/op 0 allocs/op 3.626 ns/op 0 B/op 0 allocs/op 3.92

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.