Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover middleware: Added, fiber.Ctx as a first paremeter to StackTra… #1623

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion middleware/recover/README.md
Expand Up @@ -50,7 +50,7 @@ type Config struct {
// StackTraceHandler defines a function to handle stack trace
//
// Optional. Default: defaultStackTraceHandler
StackTraceHandler func(e interface{})
StackTraceHandler func(c *fiber.Ctx, e interface{})
}
```

Expand Down
2 changes: 1 addition & 1 deletion middleware/recover/config.go
Expand Up @@ -19,7 +19,7 @@ type Config struct {
// StackTraceHandler defines a function to handle stack trace
//
// Optional. Default: defaultStackTraceHandler
StackTraceHandler func(e interface{})
StackTraceHandler func(c *fiber.Ctx, e interface{})
}

var defaultStackTraceBufLen = 1024
Expand Down
4 changes: 2 additions & 2 deletions middleware/recover/recover.go
Expand Up @@ -8,7 +8,7 @@ import (
"github.com/gofiber/fiber/v2"
)

func defaultStackTraceHandler(e interface{}) {
func defaultStackTraceHandler(c *fiber.Ctx, e interface{}) {
buf := make([]byte, defaultStackTraceBufLen)
buf = buf[:runtime.Stack(buf, false)]
_, _ = os.Stderr.WriteString(fmt.Sprintf("panic: %v\n%s\n", e, buf))
Expand All @@ -30,7 +30,7 @@ func New(config ...Config) fiber.Handler {
defer func() {
if r := recover(); r != nil {
if cfg.EnableStackTrace {
cfg.StackTraceHandler(r)
cfg.StackTraceHandler(c, r)
}

var ok bool
Expand Down