Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Return an instance of *fiber.Error when no handler found #1847

Merged
merged 4 commits into from Apr 5, 2022
Merged

RFC: Return an instance of *fiber.Error when no handler found #1847

merged 4 commits into from Apr 5, 2022

Commits on Apr 3, 2022

  1. Return an instance of *fiber.Error when no handler found

    When a handler cannot be found for a given path, previously Fiber
    would construct a plaintext response that cannot be modified.
    
    This commit switches to returning a new instance of `*fiber.Error`
    with identical error message so that users can customise the look
    of their 404 pages.
    
    Signed-off-by: AKP <tom@tdpain.net>
    codemicro committed Apr 3, 2022
    Copy the full SHA
    974e081 View commit details
    Browse the repository at this point in the history
  2. Fix Test_App_Next_Method

    This test was failing as the error returned by `c.Next()` that's
    required to generate the correct 404 status code was not being
    passed through the middleware and being silently ignored.
    
    Signed-off-by: AKP <tom@tdpain.net>
    codemicro committed Apr 3, 2022
    Copy the full SHA
    b8e7706 View commit details
    Browse the repository at this point in the history
  3. Fix Test_Logger_All

    Signed-off-by: AKP <tom@tdpain.net>
    codemicro committed Apr 3, 2022
    Copy the full SHA
    0b31781 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. Fix Test_Cache_WithHeadThenGet test

    As far as I can tell, this test is meant to check that a cached
    HEAD request to a given endpoint does not return the cached
    content to a GET request to the same endpoint, and the test has
    been altered to correctly check for this.
    
    Signed-off-by: AKP <tom@tdpain.net>
    codemicro committed Apr 4, 2022
    Copy the full SHA
    76fc307 View commit details
    Browse the repository at this point in the history