Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update code comments for helping IDEs and fix unhandled error in test #2099

Merged
merged 35 commits into from Sep 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
fe7f105
fix unhandled errors
Kamandlou Aug 26, 2022
7f1028d
fix unhandled error in cache package test
Kamandlou Aug 26, 2022
bf387fa
omit variable type
Kamandlou Aug 26, 2022
d09213b
omit variable type
Kamandlou Aug 26, 2022
14b6646
rename variable because collide with the imported package name
Kamandlou Aug 26, 2022
1c45f7e
handle file error on closing
Kamandlou Aug 26, 2022
a021d0c
Merge branch 'gofiber:master' into master
Kamandlou Aug 26, 2022
89bf878
fix unhandled in common_linux.go
Kamandlou Aug 28, 2022
8dded84
Merge branch 'gofiber:master' into master
Kamandlou Aug 29, 2022
08a9256
fix unhandled errors in helpers_test.go
Kamandlou Aug 29, 2022
038315d
fix unhandled errors in listen_test.go
Kamandlou Aug 30, 2022
e5b8dad
remove unused parameter in emptyHandler method
Kamandlou Aug 30, 2022
92e6920
refactor path.go
Kamandlou Sep 1, 2022
3086fd2
unhandled error in hooks test
Kamandlou Sep 1, 2022
73c9987
Merge branch 'gofiber:master' into master
Kamandlou Sep 2, 2022
8b466c3
fix unhandled errors in app_test.go
Kamandlou Sep 2, 2022
f1f46b1
Merge pull request #1 from Kamandlou/dev
Kamandlou Sep 2, 2022
a125a5f
fix unhandled errors in ctx_test.go
Kamandlou Sep 2, 2022
d00514c
Merge pull request #2 from Kamandlou/dev
Kamandlou Sep 3, 2022
81a0bc5
✨ fix unhandled errors in helpers_test.go
Kamandlou Sep 4, 2022
9ba9001
Merge branch 'gofiber:master' into master
Kamandlou Sep 4, 2022
83885d6
Merge pull request #3 from Kamandlou/dev
Kamandlou Sep 4, 2022
cec4b83
revert app_test.go
Kamandlou Sep 5, 2022
02aa986
Merge pull request #4 from Kamandlou/dev
Kamandlou Sep 5, 2022
afd7b13
remove redundant parentheses and update comments
Kamandlou Sep 11, 2022
9bbd11b
Merge branch 'gofiber:master' into master
Kamandlou Sep 11, 2022
8f7815b
Merge pull request #5 from Kamandlou/dev
Kamandlou Sep 11, 2022
85f8db4
update code comment for helping ide
Kamandlou Sep 16, 2022
6b26a95
update code comment for helping ide
Kamandlou Sep 16, 2022
fa957c4
Merge branch 'gofiber:master' into master
Kamandlou Sep 16, 2022
998de32
Merge pull request #6 from Kamandlou/dev
Kamandlou Sep 16, 2022
09e6942
fix unhandled error in app_test.go
Kamandlou Sep 18, 2022
0669ef0
update code comments for helping IDEs
Kamandlou Sep 18, 2022
b47bc73
Merge branch 'gofiber:master' into master
Kamandlou Sep 18, 2022
3b81225
Merge pull request #7 from Kamandlou/dev
Kamandlou Sep 18, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion app_test.go
Expand Up @@ -1202,7 +1202,8 @@ func Benchmark_App_ETag(b *testing.B) {
app := New()
c := app.AcquireCtx(&fasthttp.RequestCtx{})
defer app.ReleaseCtx(c)
c.Send([]byte("Hello, World!"))
err := c.Send([]byte("Hello, World!"))
utils.AssertEqual(b, nil, err)
for n := 0; n < b.N; n++ {
setETag(c, false)
}
Expand Down
2 changes: 1 addition & 1 deletion ctx.go
Expand Up @@ -1226,7 +1226,7 @@ func (c *Ctx) Redirect(location string, status ...int) error {
return nil
}

// Add vars to default view var map binding to template engine.
// Bind Add vars to default view var map binding to template engine.
// Variables are read by the Render method and may be overwritten.
func (c *Ctx) Bind(vars Map) error {
// init viewBindMap - lazy map
Expand Down
2 changes: 1 addition & 1 deletion group.go
Expand Up @@ -48,7 +48,7 @@ func (grp *Group) Mount(prefix string, fiber *App) Router {
return grp
}

// Assign name to specific route.
// Name Assign name to specific route.
func (grp *Group) Name(name string) Router {
grp.app.mutex.Lock()
if strings.HasPrefix(grp.Prefix, grp.app.latestGroup.Prefix) {
Expand Down
2 changes: 1 addition & 1 deletion hooks.go
@@ -1,6 +1,6 @@
package fiber

// Handlers define a function to create hooks for Fiber.
// OnRouteHandler Handlers define a function to create hooks for Fiber.
type OnRouteHandler = func(Route) error
type OnNameHandler = OnRouteHandler
type OnGroupHandler = func(Group) error
Expand Down