Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix query string parameter pass to fiber context #2164

Merged
merged 2 commits into from Oct 20, 2022
Merged

[Bug] Fix query string parameter pass to fiber context #2164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3656b4a
Remove dump to keep querystring param when test
joseroberto Oct 20, 2022
f0e667d
Remove unused import
joseroberto Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions app.go
View file
Open in desktop
Expand Up @@ -9,7 +9,6 @@ package fiber

import (
"bufio"
"bytes"
"errors"
"fmt"
"net"
Expand Down Expand Up @@ -883,11 +882,6 @@ func (app *App) Test(req *http.Request, msTimeout ...int) (resp *http.Response,
return nil, err
}

// adding back the query from URL, since dump cleans it
dumps := bytes.Split(dump, []byte(" "))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the description and title of the PR should be filled in according to pull request template .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that!!!

dumps[1] = []byte(req.URL.String())
dump = bytes.Join(dumps, []byte(" "))

// Create test connection
conn := new(testConn)

Expand Down