Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ v3: (refactor): modify storage interface and add context.Context #2300

Draft
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

li-jin-gou
Copy link
Contributor

@li-jin-gou li-jin-gou commented Jan 16, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Explain the details for making this change. What existing problem does the pull request solve?

Sometimes we need to pass ctx for use tracer and timeout control, so I add a ctx args to interface.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - https://github.com/gofiber/docs for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@li-jin-gou li-jin-gou force-pushed the reactor/modify_storage_interface branch from 7488c13 to f74a69e Compare January 16, 2023 15:56
@li-jin-gou li-jin-gou changed the title reactor: modify storage inteaface and add contxt.Context [wip]reactor: modify storage inteaface and add contxt.Context Jan 16, 2023
@li-jin-gou li-jin-gou changed the title [wip]reactor: modify storage inteaface and add contxt.Context reactor: modify storage inteaface and add contxt.Context Jan 16, 2023
@li-jin-gou li-jin-gou force-pushed the reactor/modify_storage_interface branch from f74a69e to c99a521 Compare January 16, 2023 17:05
@gaby gaby changed the title reactor: modify storage inteaface and add contxt.Context reactor: modify storage interface and add context.Context Jan 18, 2023
@efectn
Copy link
Member

efectn commented Jan 24, 2023

I'm OK with this change but it's breaking-change for v2. We should do it for v3. Can you change target to v3-beta @li-jin-gou

@li-jin-gou
Copy link
Contributor Author

I'm OK with this change but it's breaking-change for v2. We should do it for v3. Can you change target to v3-beta @li-jin-gou

thanks

@efectn efectn changed the title reactor: modify storage interface and add context.Context v3: (refactor): modify storage interface and add context.Context Feb 2, 2023
@efectn efectn changed the title v3: (refactor): modify storage interface and add context.Context ♻️ v3: (refactor): modify storage interface and add context.Context Feb 2, 2023
@ReneWerner87 ReneWerner87 added this to the v3 milestone Oct 18, 2023
@ReneWerner87
Copy link
Member

@gofiber/maintainers what do we do with this solution, do we want to pursue it further? for this we would have to adapt the storage interface

@efectn
Copy link
Member

efectn commented Jan 19, 2024

@gofiber/maintainers what do we do with this solution, do we want to pursue it further? for this we would have to adapt the storage interface

We can add new methods like SetWithContext, GetWithContext

@efectn efectn marked this pull request as draft February 11, 2024 23:06
@ReneWerner87 ReneWerner87 linked an issue Apr 17, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

📝 [v3 Proposal]: Improve Storage Interface
3 participants