Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敟 v3 (feature): Adding GetReqHeaders and GetRespHeaders #2831

Merged
merged 3 commits into from Feb 5, 2024

Conversation

brunodmartins
Copy link
Contributor

@brunodmartins brunodmartins commented Feb 5, 2024

Description

Adding GetReqHeaders and GetRespHeaders, that had not been copied from v2 to v3

Fixes #2799

Changes Introduced

Both features and tests (unit and benchamark) were copied and adapted from v2, without major changes.

  • Benchmarks: Describe any performance benchmarks and improvements related to the changes.
  • Documentation Update: Detail the updates made to the documentation and links to the changed files.
  • Changelog/What's New: Include a summary of the additions for the upcoming release notes.
  • Migration Guide: If necessary, provide a guide or steps for users to migrate their existing code to accommodate these changes.
  • API Alignment with Express: Explain how the changes align with the Express API.
  • API Longevity: Discuss the steps taken to ensure that the new or updated APIs are consistent and not prone to breaking changes.
  • Examples: Provide examples demonstrating the new features or changes in action.

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to existing features and functionality)
  • Documentation update (changes to documentation)
  • Performance improvement (non-breaking change which improves efficiency)
  • Code consistency (non-breaking change which improves code reliability and robustness)

Checklist

Before you submit your pull request, please make sure you meet these requirements:

  • Followed the inspiration of the Express.js framework for new functionalities, making them similar in usage.
  • Conducted a self-review of the code and provided comments for complex or critical parts.
  • Updated the documentation in the /docs/ directory for Fiber's documentation.
  • Added or updated unit tests to validate the effectiveness of the changes or new features.
  • Ensured that new and existing unit tests pass locally with the changes.
  • Verified that any new dependencies are essential and have been agreed upon by the maintainers/community.
  • Aimed for optimal performance with minimal allocations in the new code.
  • Provided benchmarks for the new code to analyze and improve upon.

Commit Formatting

Please use emojis in commit messages for an easy way to identify the purpose or intention of a commit. Check out the emoji cheatsheet here: CONTRIBUTING.md

Signed-off-by: brunodmartins <bdm2943@icloud.com>
Signed-off-by: brunodmartins <bdm2943@icloud.com>
@brunodmartins
Copy link
Contributor Author

Not related to the PR, but I notice that some tests are randomly failling on gofiber:main..maybe there is a conflict on test execution

Signed-off-by: brunodmartins <bdm2943@icloud.com>
@brunodmartins brunodmartins changed the title Adding GetReqHeaders and GetRespHeaders 馃敟 v3: (feature) Adding GetReqHeaders and GetRespHeaders Feb 5, 2024
@brunodmartins brunodmartins changed the title 馃敟 v3: (feature) Adding GetReqHeaders and GetRespHeaders 馃敟 v3 (feature): Adding GetReqHeaders and GetRespHeaders Feb 5, 2024
@ReneWerner87
Copy link
Member

@efectn was there a reason why it was forgotten during the merge? can we implement this pattern better?

@efectn
Copy link
Member

efectn commented Feb 5, 2024

@efectn was there a reason why it was forgotten during the merge? can we implement this pattern better?

I suppose i removed them in favor of https://github.com/gofiber/fiber/tree/main/binder#binding-into-the-map. Anyway it will change with #2006. So the PR can be merged

@ReneWerner87 ReneWerner87 merged commit 9b0a99b into gofiber:main Feb 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

馃Ч [v3 Maintenance]: GetReqHeaders and GetRespHeaders are missing from the main branch but still documented
4 participants