New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to adopt Monace editor instead of Ace editor #13
Conversation
* Add README.md
@@ -0,0 +1,6 @@ | |||
# In progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to add this in prev. commits
"bootstrap": "4.3.1", | ||
"connected-react-router": "6.4.0", | ||
"functional-immutable": "1.0.1", | ||
"history": "4.9.0", | ||
"immutable": "4.0.0-rc.12", | ||
"lodash": "4.17.14", | ||
"monaco-editor": "0.17.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
); | ||
}) => { | ||
// todo - find better logic to set editor height | ||
const height = ((editorText.split('\n').length) * LINE_HEIGHT) + PADDING; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hacky line height
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 馃檹馃徏
Dropped
react-ace
and broughtreact-monaco-editor
instead ;)^^ But I couldn't make the editor height fit in the container yet 馃槄