Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add membership=true back for gitlab replication adapter #20400

Merged
merged 2 commits into from
May 15, 2024

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented May 7, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #20401

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@zyyw zyyw added area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... target/2.11.0 labels May 7, 2024
@zyyw zyyw requested a review from a team as a code owner May 7, 2024 11:40
@zyyw zyyw removed the target/2.11.0 label May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.36%. Comparing base (b7b8847) to head (e8ce642).
Report is 186 commits behind head on main.

❗ Current head e8ce642 differs from pull request most recent head 2101a25. Consider uploading reports for the commit 2101a25 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20400      +/-   ##
==========================================
- Coverage   67.56%   66.36%   -1.20%     
==========================================
  Files         991     1042      +51     
  Lines      109181   113117    +3936     
  Branches     2719     2830     +111     
==========================================
+ Hits        73768    75071    +1303     
- Misses      31449    33986    +2537     
- Partials     3964     4060      +96     
Flag Coverage Δ
unittests 66.36% <100.00%> (-1.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/reg/adapter/gitlab/client.go 48.62% <100.00%> (ø)

... and 565 files with indirect coverage changes

@zyyw
Copy link
Contributor Author

zyyw commented May 7, 2024

@lxShaDoWxl @chlins Could you please help to review it? Thanks

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove could resolve the 500, but we need to figure out the meaning of search_namespaces.

@zyyw
Copy link
Contributor Author

zyyw commented May 8, 2024

Remove could resolve the 500, but we need to figure out the meaning of search_namespaces.

@lxShaDoWxl Could you please kindly provide some insights on this? Although we have read through this doc (search by search_namespaces), the Description of search_namespaces is still not very clear to us.

@wy65701436
Copy link
Contributor

@lxShaDoWxl can you leave your comments?

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw changed the title fix: update urlAPI when calling gitlabClientAPI add membership=true back for gitlab replication adapter May 15, 2024
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw enabled auto-merge (squash) May 15, 2024 10:02
@zyyw zyyw merged commit bb6c724 into goharbor:main May 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... release-note/update Update or Fix target/2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot to create pull-based replication from gitlab to Harbor
7 participants