commands: Fix data race in test

Note that this is a test fix only.

commands/commandeer.go

@@ -302,6 +302,7 @@ func (c *commandeer) loadConfig() error {
 	cfg := c.DepsCfg
 	c.configured = false
 	cfg.Running = c.running
+	loggers.PanicOnWarning.Store(c.h.panicOnWarning)
 
 	var dir string
 	if c.h.source != "" {

commands/commands.go

@@ -208,9 +208,10 @@ type hugoBuilderCommon struct {
 	baseURL     string
 	environment string
 
-	buildWatch bool
-	poll       string
-	clock      string
+	buildWatch     bool
+	panicOnWarning bool
+	poll           string
+	clock          string
 
 	gc bool
 
@@ -299,7 +300,7 @@ func (cc *hugoBuilderCommon) handleFlags(cmd *cobra.Command) {
 	cmd.Flags().Bool("enableGitInfo", false, "add Git revision, date, author, and CODEOWNERS info to the pages")
 	cmd.Flags().BoolVar(&cc.gc, "gc", false, "enable to run some cleanup tasks (remove unused cache files) after the build")
 	cmd.Flags().StringVar(&cc.poll, "poll", "", "set this to a poll interval, e.g --poll 700ms, to use a poll based approach to watch for file system changes")
-	cmd.Flags().BoolVar(&loggers.PanicOnWarning, "panicOnWarning", false, "panic on first WARNING log")
+	cmd.Flags().BoolVar(&cc.panicOnWarning, "panicOnWarning", false, "panic on first WARNING log")
 	cmd.Flags().Bool("templateMetrics", false, "display metrics about template executions")
 	cmd.Flags().Bool("templateMetricsHints", false, "calculate some improvement hints when combined with --templateMetrics")
 	cmd.Flags().BoolP("forceSyncStatic", "", false, "copy all files when static is changed.")

commands/hugo.go

@@ -255,6 +255,7 @@ func initializeFlags(cmd *cobra.Command, cfg config.Provider) {
 	setValueFromFlag(cmd.Flags(), "destination", cfg, "publishDir", false)
 	setValueFromFlag(cmd.Flags(), "printI18nWarnings", cfg, "logI18nWarnings", false)
 	setValueFromFlag(cmd.Flags(), "printPathWarnings", cfg, "logPathWarnings", false)
+
 }
 
 func setValueFromFlag(flags *flag.FlagSet, key string, cfg config.Provider, targetKey string, force bool) {

common/loggers/loggers.go

@@ -21,6 +21,7 @@ import (
 	"os"
 	"regexp"
 	"runtime"
+	"sync/atomic"
 	"time"
 
 	"github.com/gohugoio/hugo/common/terminal"
@@ -31,7 +32,7 @@ import (
 var (
 	// Counts ERROR logs to the global jww logger.
 	GlobalErrorCounter *jww.Counter
-	PanicOnWarning     bool
+	PanicOnWarning     atomic.Bool
 )
 
 func init() {
@@ -136,14 +137,14 @@ const panicOnWarningMessage = "Warning trapped. Remove the --panicOnWarning flag
 
 func (l *logger) Warnf(format string, v ...any) {
 	l.WARN.Printf(format, v...)
-	if PanicOnWarning {
+	if PanicOnWarning.Load() {
 		panic(panicOnWarningMessage)
 	}
 }
 
 func (l *logger) Warnln(v ...any) {
 	l.WARN.Println(v...)
-	if PanicOnWarning {
+	if PanicOnWarning.Load() {
 		panic(panicOnWarningMessage)
 	}
 }

helpers/general.go

@@ -415,7 +415,7 @@ func Deprecated(item, alternative string, err bool) {
 		DistinctErrorLog.Errorf("%s is deprecated and will be removed in Hugo %s. %s", item, hugo.CurrentVersion.Next().ReleaseVersion(), alternative)
 	} else {
 		var warnPanicMessage string
-		if !loggers.PanicOnWarning {
+		if !loggers.PanicOnWarning.Load() {
 			warnPanicMessage = "\n\nRe-run Hugo with the flag --panicOnWarning to get a better error message."
 		}
 		DistinctWarnLog.Warnf("%s is deprecated and will be removed in a future release. %s%s", item, alternative, warnPanicMessage)

helpers/general_test.go

@@ -65,10 +65,10 @@ func TestDistinctLoggerDoesNotLockOnWarningPanic(t *testing.T) {
 
 	// Set PanicOnWarning to true to reproduce issue 9380
 	// Ensure global variable loggers.PanicOnWarning is reset to old value after test
-	if loggers.PanicOnWarning == false {
-		loggers.PanicOnWarning = true
+	if !loggers.PanicOnWarning.Load() {
+		loggers.PanicOnWarning.Store(true)
 		defer func() {
-			loggers.PanicOnWarning = false
+			loggers.PanicOnWarning.Store(false)
 		}()
 	}