Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add theme ardeidae #429

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LuisSousaRego
Copy link

No description provided.

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for hugothemes ready!

Name Link
🔨 Latest commit 48b7e35
🔍 Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/65ef27b4dbf62f0008c616f4
😎 Deploy Preview https://deploy-preview-429--hugothemes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hugo-sid
Copy link
Member

Thanks for adding Ardeidae theme.

The link to demo site on your readme shows this:

image

This doesn't match the screenshot image(s) that you have provided.

Can you please fix the demo website?

@leoheitmannruiz
Copy link
Contributor

leoheitmannruiz commented Mar 12, 2024

The demo site looks fine on my end.

Edit: Ups, sorry. In Firefox the site looks fine, but not in Chromium and Safari.

@leoheitmannruiz
Copy link
Contributor

leoheitmannruiz commented Mar 12, 2024

I believe this is due to the fact that the hrefs of the stylesheets use http, so when you're on the https version of the site they aren't loaded (in Chromium and Safari, Firefox doesn't seem to care).

@LuisSousaRego
Copy link
Author

Thanks for noticing! Should be fixed now

@leoheitmannruiz
Copy link
Contributor

leoheitmannruiz commented Mar 20, 2024

Out of curiosity: why use absolute links instead of relative ones?

Edit: Not just for the CSS, but for everything than may be relative.

@hugo-sid
Copy link
Member

hugo-sid commented Mar 21, 2024

@LuisSousaRego thanks for fixing the demo website.

Can you could include some instructions on how to use your theme in the README file?

@LuisSousaRego
Copy link
Author

@LuisSousaRego thanks for fixing the demo website.

Can you could include some instructions on how to use your theme in the README file?

sure! done

@LuisSousaRego
Copy link
Author

Out of curiosity: why use absolute links instead of relative ones?

Edit: Not just for the CSS, but for everything than may be relative.

good question, I don't remember why I used abs urls in the first place, but now that you mentioned it I switched to using rel urls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants