New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire up redux and react-navigation #7
Conversation
Note: I had to disable the Flow pre-commit check, because it was checking react-navigation itself, which introduced well over a hundred errors. I imagine there's a way to suppress that; I'll make an issue to look into that later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to run this successfully and it works like you would expect. Pretty much everything looks fine to me. One thing I would say is that I think its best to avoid eslint-disable-next-line
if possible, so if there's gonna be a bunch of those then might want to consider making it the general rule.
Opened #10 for the Flow issues with react-navigation. |
I agree in general. In these cases, I used it for a few specific rules, so let's enumerate and discuss them here:
|
Unfortunately, the bug in |
Initial bare-bones experimentation to get something working. Very rough; will change considerably, soon.
Initial bare-bones experimentation to get something working. Very rough;
will change considerably, soon. The next iteration will actually have some
sample Redux code to close the loop on how some simple app activities
(such as logging in) will get accomplished using actions and reducers.
Also missing lots of documentation, sadly. Will try to get to that tomorrow.
Main design decisions that I'm proposing (feedback welcome):