refactor: pin setup-gcloud gh action to v0 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KaylaNguyen
commented
Dec 29, 2021
•
KaylaNguyen
commented
- Pin setup-gcloud gh action to v0 instead of head
- Typo fix
- qa changes equivalent of changes to master
- switch default logStream from stdout to stderr #272
- Add Go 1.16 to tested Go versions #255
- Fix header name to associate log entry & trace #263
KaylaNguyen
changed the title
jinglundong
reviewed
Jan 5, 2022
| @@ -70,7 +70,7 @@ jobs: | |||
| restore-keys: | | |||
| ${{ runner.os }}-${{ matrix.go-version }}-go- | |||
| - name: Set up Cloud SDK | |||
| uses: google-github-actions/setup-gcloud@master | |||
| uses: google-github-actions/setup-gcloud@v0 | |||
There was a problem hiding this comment.
Can you help me understand why "uses" v0 only is sufficient? I'm trying to make sure we don't lose CI coverage. In other words, why not using two workflows one for v0 (like staging?) and another one for master?
There was a problem hiding this comment.
setup-gcloud github action repo is renaming their master branch so they're suggesting to pin to v0 instead: https://github.com/google-github-actions/setup-gcloud#-notices
There was a problem hiding this comment.
I see. It's an official rename. LGTM.
jinglundong
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.