respect GAE_ENV=localdev #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zevdg
commented
Jul 12, 2022
| @@ -131,5 +131,5 @@ func fullyQualifiedAppID(_ netcontext.Context) string { | |||
| } | |||
|
|
|||
| func IsDevAppServer() bool { | |||
| return os.Getenv("RUN_WITH_DEVAPPSERVER") != "" | |||
| return os.Getenv("RUN_WITH_DEVAPPSERVER") != "" || os.Getenv("GAE_ENV") == "localdev" | |||
There was a problem hiding this comment.
FYI: in the case where these two variable disagree (e.g. RUN_WITH_DEVAPPSERVER=1 GAE_ENV=standard) this code trusts the legacy RUN_WITH_DEVAPPSERVER over the new GAE_ENV. IMO this is the best option as it is less likely to break existing test environments that may be configured this way, and lets people start using the new variable in those envs. We can update this logic and/or totally remove RUN_WITH_DEVAPPSERVER in a later release.
zevdg
force-pushed
the
gae_env_localdev
branch
2 times, most recently
from
be85e9f
to
7071ee1
Compare
jinglundong
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public docs at https://cloud.google.com/appengine/docs/standard/go/testing-and-deploying-your-app#detecting_application_runtime_environment tell you that GAE_ENV is the value to switch on to determine if you're running in devappserver or not.
appengine.IsDevAppserver()should obviously use the same variable that we encourage users to check directly.