remove golang.org/x/net dependency #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The golang.org/x/net/context package is an alias for stdlib context since go1.7 (see https://go-review.googlesource.com/72570) This patch replaces all uses of it for stdlib context. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
@jinglundong @jihuin ptal 🤗 |
jihuin
approved these changes
Dec 13, 2022
|
Hmm.. I'm not familiar with CI on this repo; are these failures related to my changes, or a general issue? |
|
@jihuin do you have some plans to merge this and release new version? |
|
FWIW, looks like the failures are due to |
|
I don't think the test failures are caused by this PR, but not too sure. We could confirm that by running the same test against mainline/master branch (or a dummy change of the mainline/master branch). @jihuin or I might be able to take a closer look next week. Meanwhile, if this is urgent, please feel free to verify it as well. |
|
I ran the same test in our corp code base. All three failed tests were skipped when running in corp. |
|
We can deal with the test failures separately. #302 |
|
Thanks! |
sg0hsmt
added a commit
to sg0hsmt/appengine
that referenced
this pull request
Mar 9, 2024
Use standard context instead of golang.org/x/net/context, and remove dependency. refs: golang#295
sg0hsmt
added a commit
to sg0hsmt/appengine
that referenced
this pull request
Apr 10, 2024
Use standard context instead of golang.org/x/net/context, and remove dependency. refs: golang#295
kennethye1
pushed a commit
that referenced
this pull request
Apr 10, 2024
Use standard context instead of golang.org/x/net/context, and remove dependency. refs: #295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The golang.org/x/net/context package is an alias for stdlib context
since go1.7 (see https://go-review.googlesource.com/72570)
This patch replaces all uses of it for stdlib context.
The second commit renames the internal App Engine "context" type, so that
the import aliases can be removed; happy to either drop that commit, or
to squash it with the first one to reduce code-churn.