fix: regenerate all protos under new namespace #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be wire compat as field numbers did not change and package is not apart of the serialization. I appened `.v2` to each proto package so that these protos can register distinctly from the protos that were copied from the v1 library. This removes runtime errors due to double registration of the same messages. Note: I did have to specially regenerate taskqueue with a special built version of protoc-gen-go in order to generate some proto1 legacy message type that is referenced. Fixes: golang#311 Fixes: googleapis/google-cloud-go#7760
|
Regarding the CI test failures, it seems like we need to upgrade the python interpreter to python 3. https://github.com/search?q=repo%3Agolang%2Fappengine%20python&type=code. I think it's caused by a recent change in gcloud. |
|
I'm trying to fix the ci tests. |
|
@jinglundong Any progress to share. This fix is needed to help people upgrade their dependencies. |
|
We will work on the python2-> 3 migration for the CI/CD of this repo. |
|
Giving a shot at #315. |
jinglundong
pushed a commit
that referenced
this pull request
Jul 11, 2023
This should be wire compat as field numbers did not change and package is not apart of the serialization. I appened `.v2` to each proto package so that these protos can register distinctly from the protos that were copied from the v1 library. This removes runtime errors due to double registration of the same messages. Note: I did have to specially regenerate taskqueue with a special built version of protoc-gen-go in order to generate some proto1 legacy message type that is referenced. Fixes: #311 Fixes: googleapis/google-cloud-go#7760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be wire compat as field numbers did not change and package is not apart of the serialization. I appened
.v2to each proto package so that these protos can register distinctly from the protos that were copied from the v1 library. This removes runtime errors due to double registration of the same messages. Note: I did have to specially regenerate taskqueue with a special built version of protoc-gen-go in order to generate some proto1 legacy message type that is referenced.Fixes: #311
Fixes: googleapis/google-cloud-go#7760