Skip to content

Commit

Permalink
Fix wrong condition in x11key Lookup for ASCII code
Browse files Browse the repository at this point in the history
* the condition was never met because rune is usually unsigned int
* the logical result of checking whether unshifted key rune is ASCII is range from 0 to 0x80
  • Loading branch information
misak113 committed Dec 29, 2020
1 parent eab1b5e commit ec7f029
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion shiny/driver/internal/x11key/x11key.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func (t *KeysymTable) Lookup(detail uint8, state uint16) (rune, key.Code) {

// The key event's code is independent of whether the shift key is down.
var c key.Code
if 0 <= unshifted && unshifted < 0x80 {
if 0 >= unshifted && unshifted < 0x80 {
c = asciiKeycodes[unshifted]
if state&LockMask != 0 {
r = unicode.ToUpper(r)
Expand Down

0 comments on commit ec7f029

Please sign in to comment.