Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use array at index instead of append as it is more efficient #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

Use array at index instead of append as it is more efficient #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions maps/maps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ package maps
// The keys will be in an indeterminate order.
func Keys[M ~map[K]V, K comparable, V any](m M) []K {
r := make([]K, 0, len(m))
i := 0
for k := range m {
r = append(r, k)
r[i] =k
i++
}
return r
}
Expand All @@ -19,8 +21,10 @@ func Keys[M ~map[K]V, K comparable, V any](m M) []K {
// The values will be in an indeterminate order.
func Values[M ~map[K]V, K comparable, V any](m M) []V {
r := make([]V, 0, len(m))
i := 0
for _, v := range m {
r = append(r, v)
r[i] =v
i++
}
return r
}
Expand Down