Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/exec: on Windows look for extensions in Run if not already done #67035

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

os/exec: on Windows look for extensions in Run if not already done #67035

wants to merge 7 commits into from
+20 −1

Commits on Apr 25, 2024

  1. os/exec: not add a suffix to Cmd.Path 

    For avoid data race for cmd.Path , in CL 527820 fixed data race , but addition of suffixe as shown in golang#66586 was also introduced.
The result of call lookExtensions is actually the name passed to os.StartProcess,
But solutions at the time chose to reuse cmd.Path to represent the name passed to os.StartProcess,since this results in golang#66586,
So use new field save call lookExtensions result.

Fixes golang#66586

Change-Id: Ib1baa6d7803f9471af6e38bcb55f0298422e6743
    @qiulaidongfeng
    qiulaidongfeng committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    78e0ae5 View commit details
    Browse the repository at this point in the history

  2. n 

    Change-Id: Iaf48768865f63b9d828a2bf46478e72da65891c7
    @qiulaidongfeng
    qiulaidongfeng committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    fd6c529 View commit details
    Browse the repository at this point in the history

  3. n 

    Change-Id: I23878885974cddceb110566020f44a776e9af2f4
    @qiulaidongfeng
    qiulaidongfeng committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e1489ac View commit details
    Browse the repository at this point in the history

  4. n 

    Change-Id: Ia532697ea429907567ab156f6f50059a15e90fbb
    @qiulaidongfeng
    qiulaidongfeng committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    be41db8 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. n 

    Change-Id: Ia5035a9e583fffee355265ee18cb10609d9c14c1
    @qiulaidongfeng
    qiulaidongfeng committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    d9ffb2d View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. n 

    Change-Id: I22c8737d1c6201f5d1b63ff70b85b04df3863e0f
    @qiulaidongfeng
    qiulaidongfeng committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    16f6808 View commit details
    Browse the repository at this point in the history

  2. n 

    Change-Id: I3d1f59eb50c754715d333526b84f7cebee65476a
    @qiulaidongfeng
    qiulaidongfeng committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    119b230 View commit details
    Browse the repository at this point in the history