New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/url: make the URL not escape to the heap when parsing #67095
Conversation
This PR (HEAD: c57111d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/582175. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/582175. |
Message from Mateusz Poliwczak: Patch Set 1: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/582175. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-28T12:37:31Z","revision":"96fb28dfb661c2050c284019163fb3c26c56a295"} Please don’t reply on this GitHub thread. Visit golang.org/cl/582175. |
Message from Mateusz Poliwczak: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/582175. |
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64-newinliner has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/582175. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/582175. |
Change-Id: I5a543904157cfad67c512d7792c9810e90929ccf
c57111d
to
894d0fa
Compare
This PR (HEAD: 894d0fa) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/582175. Important tips:
|
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/582175. |
Message from Mateusz Poliwczak: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/582175. |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/582175. |
Parse-12 324.9n ± 1% 253.0n ± 0% -22.15% (p=0.000 n=20)
Parse-12 144.0 ± 0% 0.0 ± 0% -100.00% (p=0.000 n=20)
Parse-12 1.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=20)