Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Commit

Permalink
fix Test_createPackageMap for 1.15 (#512)
Browse files Browse the repository at this point in the history
In Go 1.15 go list will return an error if any of the packages
passed to it are not valid. This differs from pervious behavior
where all of the successful results would be returned. In practice
this should not be an issue as code should contain resolvable
import paths, but this made the test fail.
  • Loading branch information
codyoss committed Jan 22, 2021
1 parent 000792a commit dcd893e
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions mockgen/mockgen_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -344,8 +344,6 @@ func Test_createPackageMap(t *testing.T) {
}{
{"golang package", "context", "context", true},
{"third party", "golang.org/x/tools/present", "present", true},
//{"modules", "rsc.io/quote/v3", "quote", true},
{"fail", "this/should/not/work", "", false},
}
var importPaths []string
for _, t := range tests {
Expand Down

0 comments on commit dcd893e

Please sign in to comment.