New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html: add PrependChild and InsertAfter #106
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: a14f476) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/329734 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/329734. |
Message from Damien Neil: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/329734. |
Message from Olav Fosse: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/329734. |
Message from Damien Neil: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/329734. |
Message from Olav Fosse: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/329734. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/329734. |
These methods complement the already existing AppendChild and InsertBefore methods in allowing for easy and safe manipulation of Node trees. For example code like oldChild.Parent.InsertBefore(newChild, oldChild.NextSibling) can now be written like oldChild.Parent.InsertAfter(newChild, oldChild) and code like node.InsertBefore(newNode, node.FirstChild) can now be written like node.PrependChild(newNode) Fixes #46960
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This PR (HEAD: f7e0d51) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/329734 to see it. Tip: You can toggle comments from me using the |
Message from Olav Fosse: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/329734. |
These methods complement the already existing AppendChild and
InsertBefore methods in allowing for easy and safe manipulation of
Node trees.
For example code like
oldChild.Parent.InsertBefore(newChild, oldChild.NextSibling)
can now be written like
oldChild.Parent.InsertAfter(newChild, oldChild)
and code like
node.InsertBefore(newNode, node.FirstChild)
can now be written like
node.PrependChild(newNode)