Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/socks: add the ability to control socks5 resolution #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sjpotter
Copy link

@sjpotter sjpotter commented Feb 5, 2023

not all servers support remote resolution, and require one to send only ip addresses

this add a new SOCKS5 dialer creation function that lets one pass in a custom *net.Resolver.

if a resolver is set on the dialer, it will use it it convert non ip addresses into ip addresses. For instance, can simply be used with net.DefaultResolver to do local resolution

not all servers support remote resolution, and require one to send only ip addresses

this add a new SOCKS5 dialer creation function that lets one pass in a custom *net.Resolver.

if a resolver is set on the dialer, it will use it it convert non ip addresses into ip addresses.  For instance, can simply be used with net.DefaultResolver to do local resolution
@sjpotter sjpotter changed the title add the ability to control socks5 resolution internal/socks: add the ability to control socks5 resolution Feb 5, 2023
@gopherbot
Copy link
Contributor

This PR (HEAD: ed93932) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/465395 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/465395.
After addressing review feedback, remember to publish your drafts!

@sjpotter
Copy link
Author

sjpotter commented Feb 7, 2023

In working more on this, I'd want to argue that there should be a Resolver interface type, so custom resolution solutions can be passed in to any place that wants a resolver. Currently, there's only a concrete Resolver type, which means any place (such as this PR) that takes a resolver cannot work as one might want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants