Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Upgrade from unsupported google.golang.org/appengine@v1.6.7 => v2 #656

Closed
trakhimenok opened this issue Jul 27, 2023 · 3 comments · May be fixed by #673
Closed

Deps: Upgrade from unsupported google.golang.org/appengine@v1.6.7 => v2 #656

trakhimenok opened this issue Jul 27, 2023 · 3 comments · May be fixed by #673
Labels
dependencies Pull requests that update a dependency file

Comments

@trakhimenok
Copy link

Should be upgraded to latest v2, at least https://pkg.go.dev/google.golang.org/appengine/v2@v2.0.4

Version: v1.6.7 Latest published: Oct 13, 2020
Version: v2.0.4 Latest Published: Jul 11, 2023

Related issues:

Environment details

All environments.

Steps to reproduce

  1. See go.mod file -
    google.golang.org/appengine v1.6.7
  2. The google.golang.org/appengine@v1.6.7 is unsupported library should NOT be referenced
@hickford hickford added the dependencies Pull requests that update a dependency file label Oct 5, 2023
@hickford
Copy link
Contributor

hickford commented Oct 6, 2023

Is there any doc explaining the difference between appengine library v1 and v2?

Also, is the v1 library definitely unsupported? https://pkg.go.dev/google.golang.org/appengine@v1.6.8 was published August 2023

@trakhimenok
Copy link
Author

Is there any doc explaining the difference between appengine library v1 and v2?

Also, is the v1 library definitely unsupported? https://pkg.go.dev/google.golang.org/appengine@v1.6.8 was published August 2023

The better question if it needs the dependency at all? A good issue advocating for removal - #615

If this heavy dependency is needed would be good to document why (justification).

@sg0hsmt
Copy link

sg0hsmt commented May 11, 2024

This issue should now be resolved.
Dependency was removed at v0.19.0 and there is no longer a dependency on google.golang.org/appengine.

refs: 3a6776a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants