Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deps: Upgrade from unsupported google.golang.org/appengine@v1.6.7 => v2 #2067

Closed
trakhimenok opened this issue Jul 13, 2023 · 4 comments
Closed

Deps: Upgrade from unsupported google.golang.org/appengine@v1.6.7 => v2 #2067

trakhimenok opened this issue Jul 13, 2023 · 4 comments
Assignees
@codyoss
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@trakhimenok
Copy link

Should be upgraded to latest v2, at least https://pkg.go.dev/google.golang.org/appengine/v2@v2.0.4

Version: v1.6.7 Latest published: Oct 13, 2020
Version: v2.0.4 Latest Published: Jul 11, 2023

Related issues:

Environment details

All environments.

Steps to reproduce

  1. See go.mod file -

    google-api-go-client/go.mod

    Line 16 in 25a3230

    google.golang.org/appengine v1.6.7
  2. The google.golang.org/appengine@v1.6.7 is unsupported library should NOT be referenced
@trakhimenok trakhimenok added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 13, 2023
@codyoss
Copy link
Member

codyoss commented Jul 13, 2023

Yes, now that the patch I applied to AE is rolled out I think it is safe for us to upgrade from the client libs side. But there are likely more places upstream that will also need updating -- the main one I think of is x/oauth2

@trakhimenok
Copy link
Author

Ideally end-users should not have indirect dependencies on AppEngine v1.6.7

@trakhimenok trakhimenok mentioned this issue Jul 27, 2023
Closed
@trakhimenok
Copy link
Author

For reference - here is an issue golang/oauth2#656 and a PR golang/oauth2#673 for the same in x/oauth2.

@codyoss
Copy link
Member

codyoss commented Apr 24, 2024

This is no longer in our deps

@codyoss codyoss closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trakhimenok @codyoss