Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Move from cloud.google.com/go/compute -> cloud.google.com/go #620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pacoxu
Copy link

@pacoxu pacoxu commented Jan 10, 2023

Signed-off-by: Paco Xu paco.xu@daocloud.io

@gopherbot
Copy link
Contributor

This PR (HEAD: 348bbb9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/461087 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/461087.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Hickford:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/461087.
After addressing review feedback, remember to publish your drafts!

@pacoxu
Copy link
Author

pacoxu commented Jan 10, 2023

Matthew Hickford:

  • Why a new indirect dependency? Can it be avoided?

@codyoss googleapis/google-cloud-go#6959 link the related change for golang/oauth2 reviewer's question.

@gopherbot
Copy link
Contributor

Message from Jordan Liggitt:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/461087.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jordan Liggitt:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/461087.
After addressing review feedback, remember to publish your drafts!

@pacoxu
Copy link
Author

pacoxu commented Jan 10, 2023

Message from Jordan Liggitt:

I would prefer we wait to bump this until the metadata module drops the back reference to the main cloud module, otherwise consumers get every submodule of the cloud module added to their graph (see the massive addition to go.sum in this CL)

Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@pacoxu pacoxu changed the title upgrade cloud.google.com/go/compute/metadata from v0.2.0 to v0.2.3 deps: Move from cloud.google.com/go/compute -> cloud.google.com/go Jan 12, 2023
@gopherbot
Copy link
Contributor

This PR (HEAD: 6df6060) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/461087 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Jordan Liggitt:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/461087.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants