New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

endpoints: remove duplicated URLs from legacy packages #633

Open

stefanb wants to merge 2 commits into golang:master from stefanb:endpoints-deduplication

+68 −167

stefanb commented Feb 28, 2023

I noticed that the identical endpoint URLs are repeated in multiple packages, making them difficult to maintain.

This makes the legacy packages reference the ones defined in endpoints package in a backwards compatible manner.

stefanb added 2 commits

February 28, 2023 14:54


          endpoints: remove duplicated URLs from legacy packages

b514a93

I noticed that the identical endpoint URLs are repeated in multiple packages,
making them difficult to maintain.


          Also 2 cases with inconsistent AuthStyle

bbd977e

Contributor

gopherbot commented Feb 28, 2023

This PR (HEAD: bbd977e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/471917 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Feb 28, 2023

Message from Štefan Baebler:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/471917.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 28, 2023

Message from Matthew Hickford:

Patch Set 1: Code-Review+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/471917.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 28, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/471917.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 28, 2023

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/471917.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 7, 2023

Message from Matthew Hickford:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/471917.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 7, 2023

Message from Štefan Baebler:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/471917.
After addressing review feedback, remember to publish your drafts!

hickford added the endpoints label

Contributor

gopherbot commented Mar 8, 2023

Message from Štefan Baebler:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/471917.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Apr 11, 2023

Message from Matt Hickford:

Patch Set 1: Code-Review+1 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/471917.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment