Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
protoc-gen-go: generate XXX_OneofWrappers instead of XXX_OneofFuncs (#…
…760) The marshaler, unmarshaler, and sizer functions are unused ever since the underlying implementation was switched to be table-driven. Change the function to only return the wrapper structs. This change: * enables generated protos to drop dependencies on certain proto types * reduces the size of generated protos * simplifies the implementation of oneofs in protoc-gen-go Updates #708
- Loading branch information
8d0c54c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey guys, is there any plan to release the above changes? cheers
8d0c54c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a pressing need for it? There haven’t been that many substantial changes since v1.2 to justify a another release quite yet.
8d0c54c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future visitors coming here due to broken builds. Please read #763 (comment)