Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoc-gen-go: generate XXX_OneofWrappers instead of XXX_OneofFuncs #760

Merged
merged 1 commit into from
Nov 27, 2018
Merged

protoc-gen-go: generate XXX_OneofWrappers instead of XXX_OneofFuncs #760

merged 1 commit into from
Nov 27, 2018

Commits on Nov 26, 2018

  1. protoc-gen-go: generate XXX_OneofWrappers instead of XXX_OneofFuncs 

    The marshaler, unmarshaler, and sizer functions are unused ever since
the underlying implementation was switched to be table-driven.
Change the function to only return the wrapper structs.

This change:
* enables generated protos to drop dependencies on certain proto types
* reduces the size of generated protos
* simplifies the implementation of oneofs in protoc-gen-go

Updates #708
    @dsnet
    dsnet committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    07d8431 View commit details
    Browse the repository at this point in the history