Skip to content

Commit

Permalink
gopls/internal/test/integration/misc: reenable staticcheck test
Browse files Browse the repository at this point in the history
This test reenables the staticcheck test, which now passes
with gotypesalias={,0,1}. (Staticcheck may yet need work, but
that isn't evident to our tests.)

Updates golang/go#64581

Change-Id: I1c8acca2c6b7d16e551a5c8a68be564254713d0d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/579756
Auto-Submit: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
  • Loading branch information
adonovan authored and gopherbot committed Apr 19, 2024
1 parent 2debfbe commit 618670d
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions gopls/internal/test/integration/misc/staticcheck_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ import (
func TestStaticcheckGenerics(t *testing.T) {
testenv.NeedsGo1Point(t, 20) // staticcheck requires go1.20+

// TODO(golang/go#65249): re-enable and fix this test with gotypesalias=1.
testenv.SkipMaterializedAliases(t, "staticcheck needs updates for materialized aliases")

const files = `
-- go.mod --
module mod.com
Expand Down Expand Up @@ -83,9 +80,6 @@ var FooErr error = errors.New("foo")
func TestStaticcheckRelatedInfo(t *testing.T) {
testenv.NeedsGo1Point(t, 20) // staticcheck is only supported at Go 1.20+

// TODO(golang/go#65249): re-enable and fix this test with gotypesalias=1.
testenv.SkipMaterializedAliases(t, "staticcheck needs updates for materialized aliases")

const files = `
-- go.mod --
module mod.test
Expand Down

0 comments on commit 618670d

Please sign in to comment.