gopls: add maxUnimportedPackageNames option that makes the number of completion candidates for unimported packages configurable
#442
+272
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f completion candidates for unimported packages configurable
110y
commented
Jun 25, 2023
| @@ -101,7 +101,9 @@ func genCase(method string, param, result *Type, dir string) { | |||
| nm = "ParamConfiguration" // gopls compatibility | |||
| } | |||
| fmt.Fprintf(out, "\t\tvar params %s\n", nm) | |||
| fmt.Fprintf(out, "\t\tif err := json.Unmarshal(r.Params(), ¶ms); err != nil {\n") | |||
| fmt.Fprintf(out, "\t\tdecoder := json.NewDecoder(bytes.NewReader(r.Params()))\n") | |||
| fmt.Fprintf(out, "\t\tdecoder.UseNumber()\n") | |||
There was a problem hiding this comment.
This is needed because the default json.Unmarshal treats a number as a float type.
|
This PR (HEAD: d39db52) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/505995 to see it. Tip: You can toggle comments from me using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxUnimportedPackageNamesthat makes the number of completion candidates for unimported packages configurable