This repository has been archived by the owner on Mar 18, 2022. It is now read-only.
Updated master #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the -set_exit_status flag to goconst, inspired by the same flag on the prealloc tool [1]. I updated the help message accordingly. The exit status is set to `2` to distinguish it from an non-recoverable error, indicated by an exit status of `1`. I implemented this by hvaing the `run` function return an additional value indicating if anyIssues were found. `run` gets this information from `printOutput` and returns it directly. This is needed because `printOutput` does some additional processing of the duplicates found (namely checking if there are enough occurances of a given constant). If there is any error in the program, this always takes precedence over issues found by goconst. -- 1. https://github.com/alexkohler/prealloc
Update the usage message found in the README.
|
Or even @golangci/core-team as @golangci/team seems to miss privileges to merge it. |
|
@jirfag I can't merge this even on behalf of the @golangci/core-team :( |
|
This is some serious black magic. It makes me think that we should work with liter maintainers to enable library usage in the upstream. There are more similar forks here and I guess we can't merge PRs to them either. |
|
We should be able to use upstream version now: jgautheron@ce0d7c0 |
|
Great! I hope that we will eventually switch to upstream all our forks. |
|
Replacing fork with upstream PR: golangci/golangci-lint#1500 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates master with changes introduces in 2020. Related to golangci/golangci-lint#1495
@golangci/team, I summon you.