feat: support merge_groups for only new issues #1026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strantalis
force-pushed
the
merge-group-support
branch
from
f4e979f
to
f61e922
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
After some tests, this PR has a problem because it uses directly the PR content as a patch/diff. But when a PR is inside a merge group the patch/diff should be related to the HEAD of the targeted branch and use the "rebased" commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request looks to help resolve #956. The changes seem to be working as expected but I am not sure if I missed anything when it comes to working with merge queues.
Thanks for the feedback in advance!