gofmt: autofix missing newline at EOF (#3917)

golangci · Jun 18, 2023 · 28f0560 · 28f0560
1 parent 7cf30e7
commit 28f0560
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/pkg/golinters/gofmt_common.go b/pkg/golinters/gofmt_common.go
@@ -80,6 +80,16 @@ func (p *hunkChangesParser) parseDiffLines(h *diffpkg.Hunk) {
 		ret = append(ret, dl)
 	}
 
+	// if > 0, then the original file had a 'No newline at end of file' mark
+	if h.OrigNoNewlineAt > 0 {
+		dl := diffLine{
+			originalNumber: currentOriginalLineNumber + 1,
+			typ:            diffLineAdded,
+			data:           "",
+		}
+		ret = append(ret, dl)
+	}
+
 	p.lines = ret
 }
 

diff --git a/test/testdata/fix/in/gofmt.go b/test/testdata/fix/in/gofmt.go
@@ -7,4 +7,4 @@ package p
  		return 1 
 	}
  	return 2
-}
+}