Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add uncalled linter #3348

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat: add uncalled linter #3348

wants to merge 9 commits into from
+101 −0

Commits on Dec 17, 2022

  1. feat: add rowserr linter 

    Add rowserr a linter which checks for missing sql Rows.Err() calls
that supports generics.
    @stevenh
    stevenh committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    450301f View commit details
    Browse the repository at this point in the history

  2. chore: refactor to uncalled 

    Refactor to use uncalled which is a generic version rowserr that uses
a configuration to enable rules based checks instead of hard-coded for
database/sql Rows.Err() checks only.
    @stevenh
    stevenh committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    4d19884 View commit details
    Browse the repository at this point in the history

  3. chore: update to uncalled v0.4.0 

    Update to uncalled v0.4.0 to align with golangci-lint config style.
    @stevenh
    stevenh committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    3d69f3a View commit details
    Browse the repository at this point in the history

  4. chore: update to uncalled v0.5.0 

    Update to uncalled v0.5.0 which adds net http response close checks.
    @stevenh
    stevenh committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    92f3c5f View commit details
    Browse the repository at this point in the history

  5. chore: run go mod tidy 

    Run go mod tidy to clean up go.mod
    @stevenh
    stevenh committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    711bf0a View commit details
    Browse the repository at this point in the history

  6. feat: update to uncalled v0.7.1 

    Update to uncalled v0.7.1 which adds more checkers, adds the ability to
handle more called types including direct calls in defers.

This adds the following new rules:
- http Response.Body.Close()
- context context.CancelFunc()
    @stevenh
    stevenh committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    2512497 View commit details
    Browse the repository at this point in the history

  7. core: add default config 

    Add default config, correct want and fix linter name.
    @stevenh
    stevenh committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    a649a25 View commit details
    Browse the repository at this point in the history

  8. feat: update to v0.8.0 merge config 

    Update to v0.8.0 which adds merge config support. This improves
compatibility with golangci-lint by allowing the internal rules to be
applied and overridden with minimal configuration.
    @stevenh
    stevenh committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    5a26360 View commit details
    Browse the repository at this point in the history

  9. chore: update to uncalled v0.8.1 

    Update uncalled to v0.8.1 which addresses a config data race.
    @stevenh
    stevenh committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    602314d View commit details
    Browse the repository at this point in the history