Add support for the new golem registry #1044
Conversation
examples/blender/blender.py
Outdated
|
|
||
|
|
||
| async def main( | ||
| subnet_tag, min_cpu_threads, payment_driver=None, payment_network=None, show_usage=False | ||
| ): | ||
| package = await vm.repo( | ||
| image_hash="9a3b5d67b0b27746283cb5f287c13eab1beaa12d92a9f536b747c7ae", | ||
| image="9a3b5d67b0b27746283cb5f287c13eab1beaa12d92a9f536b747c7ae", |
There was a problem hiding this comment.
any such breaking changes should follow a proper deprecation process...
BUT, having said that, I don't think that we want to have it implemented that way - rather I think we'd like to explicitly differentiate tags from hashes
There was a problem hiding this comment.
I agree on the deprecation process - i'm just unsure how it's usually done, so please do suggest what to do.
I just think there will be less struggle for requestors if they can just define a single parameter to the package, and insert either a hash or tagged image and then yapapi automatically handles it for them. If we decide to split it up anyway, wouldn't it be smart to include some kind of check to see if they've accidentally used a hash on the tag parameter and vice versa?
|
AutoPEP8 is installed on my IDE. I wasn't aware that Yapapi follows a specific formatter type. |
I've tested this PR locally to check if everything is working as it should, and I have not come across any problems yet. I have mainly just changed the logic that is used when looking up an image.
There's 1 breaking change and that is that i've renamed
image_hashinVmRepotoimageas we are not solely relying on hashes in the future.Please check it out and give comments.