Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example reproducing partial command output issue #1102

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lucekdudek
Copy link
Contributor

No description provided.

@@ -0,0 +1 @@
*.gvmi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if anything, this should be added to the global .gitignore ... but I wouldn't add it at all ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what you want me to do then. Do you want me to upload the image? It has almost 5mb

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucekdudek no, what I meant is that if we need this ignore to be present, it should be added to the .gitignore file in the root of the repository... but on the other hand, you can also add it to your local ignores so that it doesn't show on your listings ...

by no means I wanted you to upload a GMVI file into the repo :D

@shadeofblue
Copy link
Collaborator

okay, looks good now 👍

though, I'm unsure if we want to merge it ...

@shadeofblue shadeofblue added the sdk-request issue requested by SDK team label Mar 9, 2023
@shadeofblue shadeofblue marked this pull request as draft March 9, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk-request issue requested by SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants