Using - instead of _ for Azure blob storage container name in tests #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But falling back to 'athens' if it's not set
arschles
changed the title
|
thanks for the changes. The changes look good to me; but the build for this test is failing @arschles. Seems like a key needs to be updated from what I understand, would you be able to fix it when you get a chance. |
|
@manugupt1 I am about to go on vacation for the rest of the year, but I'll bookmark this and get back to it in the new year! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
_is an invalid char in Azure blob store container names.How is the fix applied?
Using
-instead.Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.
I'm picking up where @marpio left off in #1366. I've only added one extra tiny commit to finish his PR off. @marpio when you get a chance, can you let me know if this looks ok to you?
Closes #1366