Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements to performance and stability #36

Merged
merged 11 commits into from
May 22, 2023
Merged

Various improvements to performance and stability #36

merged 11 commits into from
May 22, 2023

Commits on May 16, 2023

  1. Update to Go 1.20 

    Signed-off-by: John Howard <howardjohn@google.com>
    @howardjohn
    howardjohn committed May 16, 2023
    Configuration menu
    Copy the full SHA
    fc9e957 View commit details
    Browse the repository at this point in the history

  2. Go.mod for go 1.20 

    Signed-off-by: John Howard <howardjohn@google.com>
    @howardjohn
    howardjohn committed May 16, 2023
    Configuration menu
    Copy the full SHA
    a81e531 View commit details
    Browse the repository at this point in the history

  3. add benchmarks 

    Signed-off-by: John Howard <howardjohn@google.com>
    @howardjohn
    howardjohn committed May 16, 2023
    Configuration menu
    Copy the full SHA
    87f8876 View commit details
    Browse the repository at this point in the history

  4. Add fuzzing test 

    Signed-off-by: John Howard <howardjohn@google.com>
    @howardjohn
    howardjohn committed May 16, 2023
    Configuration menu
    Copy the full SHA
    4844bbf View commit details
    Browse the repository at this point in the history

  5. Fix CI 

    Signed-off-by: John Howard <howardjohn@google.com>
    @howardjohn
    howardjohn committed May 16, 2023
    Configuration menu
    Copy the full SHA
    471fa30 View commit details
    Browse the repository at this point in the history

  6. Improve fuzz tests 

    Signed-off-by: John Howard <howardjohn@google.com>
    @howardjohn
    howardjohn committed May 16, 2023
    Configuration menu
    Copy the full SHA
    1f7eb13 View commit details
    Browse the repository at this point in the history

  7. Fix inputs with empty keys 

    Signed-off-by: John Howard <howardjohn@google.com>
    @howardjohn
    howardjohn committed May 16, 2023
    Configuration menu
    Copy the full SHA
    2c05a51 View commit details
    Browse the repository at this point in the history

  8. Fix marshaling invalid chars 

    Signed-off-by: John Howard <howardjohn@google.com>
    @howardjohn
    howardjohn committed May 16, 2023
    Configuration menu
    Copy the full SHA
    c616a48 View commit details
    Browse the repository at this point in the history

  9. Fix known broken case 

    Signed-off-by: John Howard <howardjohn@google.com>
    @howardjohn
    howardjohn committed May 16, 2023
    Configuration menu
    Copy the full SHA
    e0f6c24 View commit details
    Browse the repository at this point in the history

  10. (hackily) remove inefficient optimization 

    ```
name                        old time/op    new time/op    delta
CreatePatch/complex-48         167µs ± 8%     156µs ± 4%   -6.85%  (p=0.001 n=10+10)
CreatePatch/large_array-48     664ms ± 1%       2ms ± 3%  -99.71%  (p=0.000 n=10+10)
CreatePatch/simple-48         2.95µs ± 2%    2.92µs ± 1%     ~     (p=0.447 n=10+10)

name                        old alloc/op   new alloc/op   delta
CreatePatch/complex-48        75.8kB ± 0%    75.0kB ± 0%   -0.95%  (p=0.000 n=10+10)
CreatePatch/large_array-48     153MB ± 0%       1MB ± 0%  -99.39%  (p=0.000 n=9+10)
CreatePatch/simple-48         1.23kB ± 0%    1.23kB ± 0%   +0.04%  (p=0.033 n=10+10)

name                        old allocs/op  new allocs/op  delta
CreatePatch/complex-48         1.20k ± 0%     1.17k ± 0%   -2.41%  (p=0.000 n=10+10)
CreatePatch/large_array-48     7.01M ± 0%     0.01M ± 0%  -99.79%  (p=0.000 n=10+10)
CreatePatch/simple-48           29.0 ± 0%      29.0 ± 0%     ~     (all equal)
```

Signed-off-by: John Howard <howardjohn@google.com>
    @howardjohn
    howardjohn committed May 16, 2023
    Configuration menu
    Copy the full SHA
    45186ed View commit details
    Browse the repository at this point in the history

  11. Fully remove dead code 

    Signed-off-by: John Howard <howardjohn@google.com>
    @howardjohn
    howardjohn committed May 16, 2023
    Configuration menu
    Copy the full SHA
    6d5c3df View commit details
    Browse the repository at this point in the history